/ok-to-test

Great. But I'm wondering isn't there also a problem in the allocate action? After the break here:

cc @Monokaix @lowang-bh @hwdef

Great. But I'm wondering isn't there also a problem in the allocate action? After the break here:

volcano/pkg/scheduler/actions/allocate/allocate.go

Line 215 in 5d66534

break

, the job is not pushed back, and the remaining pods in this job are not scheduled
cc @Monokaix @lowang-bh @hwdef

It is ok when minMember equals to total replicas.
Otherwise, maybe it need to be considered as this:

Great. But I'm wondering isn't there also a problem in the allocate action? After the break here:

volcano/pkg/scheduler/actions/allocate/allocate.go

Line 215 in 5d66534

break

, the job is not pushed back, and the remaining pods in this job are not scheduled
cc @Monokaix @lowang-bh @hwdef

It is ok when minMember equals to total replicas. Otherwise, maybe it need to be considered as this:

volcano/pkg/scheduler/actions/allocate/allocate.go

Line 224 in a61fc90

if job.NeedContinueAllocating() {

We can seperate it to another pr.

Please squash to one commit.

Great. But I'm wondering isn't there also a problem in the allocate action? After the break here:

volcano/pkg/scheduler/actions/allocate/allocate.go

Line 215 in 5d66534

break

, the job is not pushed back, and the remaining pods in this job are not scheduled
cc @Monokaix @lowang-bh @hwdef

It is ok when minMember equals to total replicas. Otherwise, maybe it need to be considered as this:

volcano/pkg/scheduler/actions/allocate/allocate.go

Line 224 in a61fc90

if job.NeedContinueAllocating() {

We can seperate it to another pr.

I think using NeedContinueAllocating is a good choice, Could you also help to fix allocate action? @hansongChina

NeedContinueAllocating()

allocate is a more sensitive action, add this logic may cause some performance issue, maybe we should reconsider that case: )

Please squash to one commit.

OK

Great. But I'm wondering isn't there also a problem in the allocate action? After the break here:

volcano/pkg/scheduler/actions/allocate/allocate.go

Line 215 in 5d66534

break

, the job is not pushed back, and the remaining pods in this job are not scheduled
cc @Monokaix @lowang-bh @hwdef

It is ok when minMember equals to total replicas. Otherwise, maybe it need to be considered as this:

volcano/pkg/scheduler/actions/allocate/allocate.go

Line 224 in a61fc90

if job.NeedContinueAllocating() {

We can seperate it to another pr.

I think using NeedContinueAllocating is a good choice, Could you also help to fix allocate action? @hansongChina
Sure. Should we use the method "NeedContinueAllocating" to make a judgment once, or directly use "continue" to let all the tasks of this job attempt to be scheduled once?

/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

/lgtm